Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatzone-desktop: 5.2.1 -> 5.2.3 #360941

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

JarvisCraft
Copy link
Contributor

@JarvisCraft JarvisCraft commented Dec 2, 2024

  • Update chatzone-desktop version from 5.2.1 to 5.2.3.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 2, 2024
@JarvisCraft
Copy link
Contributor Author

Minor version update with no functional changes thus adding backports to 24.{05,11}

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 2, 2024
@JarvisCraft JarvisCraft changed the title Chatzone desktop/v5.2.3 chatzone-desktop: 5.2.1 -> 5.2.3 Dec 2, 2024
@JarvisCraft JarvisCraft force-pushed the chatzone-desktop/v5.2.3 branch from b46a186 to a269fbf Compare December 8, 2024 17:53
@JohnRTitor
Copy link
Contributor

@ofborg build chatzone-desktop

@JarvisCraft
Copy link
Contributor Author

@JohnRTitor, thanks for quick PR review!

Seems like @ofborg does not build the package as it is unfree.

@JohnRTitor
Copy link
Contributor

I'll run a Nixpkgs-review later then. (Thought it built unfreeRedistributable)

@JohnRTitor JohnRTitor self-assigned this Dec 8, 2024
@JarvisCraft JarvisCraft force-pushed the chatzone-desktop/v5.2.3 branch from a269fbf to 4ba53df Compare December 9, 2024 11:21
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 9, 2024
@JarvisCraft
Copy link
Contributor Author

JarvisCraft commented Dec 9, 2024

Rebased via master, now the diff is minimal

@JohnRTitor JohnRTitor merged commit 6400e8d into NixOS:master Dec 9, 2024
25 of 26 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 9, 2024

Successfully created backport PR for release-24.05:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 9, 2024

Successfully created backport PR for release-24.11:

@JarvisCraft JarvisCraft deleted the chatzone-desktop/v5.2.3 branch December 9, 2024 22:35
@JarvisCraft
Copy link
Contributor Author

Thanks!

Could you please also take a look at the above-reported backports of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants