dashy-ui: fix uncalled settings override phase #360933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NixOS/nixpkgs-merge-bot merge |
|
@TheRealGramdalf merge not permitted (#305350): |
|
Ah, https://github.com/nixos/nixpkgs/tree/master/maintainers#nixpkgs-merge-bot seemed to indicate the restricted authors stipulation didn't apply - I'll get this merged normally then. |
|
A backport PR is probably a good idea, but I don't think I have the perms for that |
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 415ef7a)
1 task
prinzdezibel
pushed a commit
to prinzdezibel/nixpkgs
that referenced
this pull request
Dec 4, 2024
(cherry picked from commit 415ef7a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed what was previously the
postYarnConfigHook, as it would previously never run, causing anysettings = {...}override to have no effect.Resolves #246137
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
Footnotes
Against nixpkgs
4633a7c72337ea8fd23a4f2ba3972865e3ec685d↩