Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feishin: 0.11.1 -> 0.12.1 #359962

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feishin: 0.11.1 -> 0.12.1 #359962

merged 2 commits into from
Dec 2, 2024

Conversation

jlbribeiro
Copy link
Member

Diff: jeffvli/feishin@v0.11.1...v0.12.1
Changelog:

Maintainers: @onny and @jlbribeiro (me)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@x123
Copy link
Contributor

x123 commented Nov 28, 2024

nixpkgs-review pr 359962 output:

--------- Report for 'x86_64-linux' ---------
1 package built:
feishin

resulting binary works for me.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 29, 2024
@ofborg ofborg bot requested a review from onny November 29, 2024 15:02
eljamm
eljamm approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljamm eljamm added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 1, 2024
@onny onny merged commit 8c4d527 into NixOS:master Dec 2, 2024
40 of 41 checks passed
@emilylange emilylange added the backport release-24.11 Backport PR automatically label Jan 30, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 30, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 30, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x123 x123 x123 approved these changes

@eljamm eljamm eljamm approved these changes

@onny onny Awaiting requested review from onny

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jlbribeiro @x123 @eljamm @onny @wegank @emilylange