pkgs/by-name/[abc].+ Migrate to new Darwin SDK #355564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ec97d to
af62940
Compare
|
Result of 3 packages marked as broken and skipped:
1 package failed to build:
39 packages built:
|
tjni
reviewed
Nov 13, 2024
pkgs/by-name/ae/aegisub/package.nix
Outdated
Comment on lines
95
to
97
| ++ lib.optionals openalSupport [ | ||
| (if stdenv.hostPlatform.isDarwin then darwin.apple_sdk.frameworks.OpenAL else openal) | ||
| ] |
There was a problem hiding this comment.
This is actually kind of subtle (and you might want to extract this into its own PR for clarity):
After the refactor, on Darwin, OpenAL is always present, so this part can simply be:
++ lib.optionals (openalSupport && !stdenv.hostPlatform.isDarwin) [
openal
]
But in order to properly disable openal on Darwin, we now need
cmakeFlags = [ "-DWITH_OPENAI=OFF" ];
when openalSupport is false.
There was a problem hiding this comment.
I like the idea of dropping this in its own PR for clarity. That way we can document the change properly.
There was a problem hiding this comment.
I had to move the patch into here due to conflicts with the new default SDK
13 tasks
8a18342 to
399ac19
Compare
399ac19 to
37dd5ea
Compare
be3931a to
9eb707e
Compare
|
Closing, as we have the proof the new SDK structure migrates easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: #354146
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.