Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-studio: don't use ffmpeg-full #354934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Nov 10, 2024

The regular ffmpeg now has SVT-AV1 and AOM support enabled by default.

#271863

This effectively reverts 8a3191f

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The regular ffmpeg now has SVT-AV1 and AOM support enabled by default.

NixOS#271863

This effectively reverts 8a3191f
@Atemu Atemu added the 6.topic: closure size The final size of a derivation, including its dependencies label Nov 10, 2024
@Atemu Atemu requested a review from blitz November 10, 2024 06:59
@emilazy
Copy link
Member

emilazy commented Nov 10, 2024

Nvidia hardware encoding is the most common way to use OBS. I wasn’t clear on whether our regular FFmpeg package supports it? (It really should, if we can, I think.)

@Atemu
Copy link
Member Author

Atemu commented Nov 10, 2024

nvcoded and all dependent features are enabled in headless and should work. I don't have an nvidia GPU to test though (cc @jopejoe1?).

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM then, but maybe let’s wait until branch‐off since it could technically Break Someone’s Workflow?

@Atemu
Copy link
Member Author

Atemu commented Nov 10, 2024

We could also fold this into the tree-wide ffmpeg-full dependency removal then.

@emilazy emilazy added the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 10, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2024
@jopejoe1
Copy link
Member

nvcoded and all dependent features are enabled in headless and should work. I don't have an nvidia GPU to test though (cc @jopejoe1?).

Should be fine l, but will test this later.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off 6.topic: closure size The final size of a derivation, including its dependencies 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants