-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-studio: don't use ffmpeg-full #354934
base: master
Are you sure you want to change the base?
Conversation
The regular ffmpeg now has SVT-AV1 and AOM support enabled by default. NixOS#271863 This effectively reverts 8a3191f
Nvidia hardware encoding is the most common way to use OBS. I wasn’t clear on whether our regular FFmpeg package supports it? (It really should, if we can, I think.) |
nvcoded and all dependent features are enabled in headless and should work. I don't have an nvidia GPU to test though (cc @jopejoe1?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM then, but maybe let’s wait until branch‐off since it could technically Break Someone’s Workflow?
We could also fold this into the tree-wide ffmpeg-full dependency removal then. |
Should be fine l, but will test this later. |
The regular ffmpeg now has SVT-AV1 and AOM support enabled by default.
#271863
This effectively reverts 8a3191f
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.