-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgs/by-name/[ab].+: migrate to new apple sdk #354097
Conversation
770809d
to
0533b22
Compare
|
0533b22
to
012de1e
Compare
012de1e
to
cd8beb6
Compare
cd8beb6
to
ceb4fb3
Compare
@emilazy That should be everything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now! I did a survey of OpenSSL dependencies:
-
agate
usestokio-rustls
withring
and therefore shouldn’t require OpenSSL on any platform AFAIK; can you drop thebuildInputs
entirely? -
asfa
usesssh2
which requires OpenSSL, so that seems fine. -
asm-lsp
usesreqwest
which uses native TLS by default; OpenSSL dependency should be conditioned on!stdenv.hostPlatform.isDarwin
.
I won’t block this PR on this if you don’t feel like doing it, but it’d be nice to get these cleaned up.
ceb4fb3
to
31a776f
Compare
If I do so, it fails looking for <openssl/opensslv.h>. So it needs the headers at least.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 354097
run on aarch64-linux 1
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 354097
aarch64-darwin
✅ 13 packages built:
- agate
- anchor
- asfa
- asfa.man
- asm-lsp
- atac
- attract-mode
- avbroot
- bacon
- biome
- buckle
- bulloak
- commafeed
Thank you!
Validating the new apple sdk by migrationg low-risk packages:
darwin
dependency withapple-sdk_11
apple-sdk_11
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.