Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken: fix invalid darwin hash #352981

Merged

Conversation

nicolas-goudry
Copy link
Contributor

Fixes #352944

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kirillrdy
Copy link
Member

kirillrdy commented Nov 1, 2024

this is just to check that it evals

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352981


x86_64-linux

re hash, they probably re-uploaded the zip file, if some one has old file, would be good to have a look what changec

@kirillrdy kirillrdy merged commit 2f02bdd into NixOS:master Nov 1, 2024
10 of 11 checks passed
@nicolas-goudry nicolas-goudry deleted the fix/gitkraken-10-4-1-darwin-hash branch November 1, 2024 21:56
@nicolas-goudry
Copy link
Contributor Author

@kirillrdy I may also have messed up.

Does ofborg builds darwin? I remember there was something like an issue preventing it to run on darwin. But I may be wrong.

If ofborg does build, Axosoft may also have re-uploaded the zip as you told… Sadly, I cleaned my store before NixCon so I don’t have the old zip anymore.

@kirillrdy
Copy link
Member

Ofborg doesn't build nonfree software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: GitKraken 10.4.1 hash mismatch failure on darwin
2 participants