Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduwuit: fix x86_64-darwin #352911

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Nov 1, 2024

conduwuit failed to build on x86_64-darwin because the default macOS SDK for x86_64 does not include CryptoKit and its CommonCrypto headers, which are required by the aws-lc dependency.
This is fixed by using the latest SDK instead while setting the deployment target to 10.15, the oldest macOS version that supports CryptoKit.

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird gepbird added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 1, 2024
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 2, 2024
@Aleksanaa
Copy link
Member

Could you check build failure below?

@niklaskorz
Copy link
Contributor Author

niklaskorz commented Nov 2, 2024

Could you check build failure below?

The build failure in ofborg is just a timeout. It built rocksdb and conduwuit just fine and then cancelled the checkPhase because it took longer than 60min to build the tests.

Building again on a different machine (M1 Max, building x86_64 through Rosetta) right now to see how long it takes there.

Edit: Build phase of conduwuit took 9min and check phase 6min14sec, not sure why ofborg would hang on building the tests in check phase.
Edit 2: On second look, the 60min timeout in OfBorg applies to the whole derivation. As the build phase of conduwuit already takes 45min there, of course there isn't enough time left to build the tests for the check phase in OfBorg, so this likely will never pass with the current timeout.

@wegank wegank merged commit eb90390 into NixOS:master Nov 2, 2024
38 of 39 checks passed
@girlbossceo
Copy link

Just curious is this something we should/can add to our flake?

@niklaskorz
Copy link
Contributor Author

niklaskorz commented Nov 5, 2024

Just curious is this something we should/can add to our flake?

You may have to update your lockfile first (I'm not sure if your currently two-weeks old nixpkgs-unstable reference already contains the new SDK pattern), but yes, then you can also make use of the new macOS SDK pattern. Basically the new apple-sdk derivations replace the prior need to specify every macOS framework separately. There also was an older pattern for specifying a newer SDK than the default one, but the new one reads a lot nicer and is less error prone.

Conduwuit's flake will currently not build on x86_64-darwin for the same reason described in this PR (x86_64-darwin defaults to the 10.13 SDK, which does not include CommonCrypto).

Edit: I can test Mac builds and provide a potential PR towards conduwuit this weekend.

@niklaskorz niklaskorz deleted the conduwuit-darwin-fix branch December 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants