pymupdf: bundle mupdf package
#352845
Open
pymupdf: bundle mupdf package
#352845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Fixes #332384 |
|
@ofborg build python312Packages.pymupdf |
FliegendeWurst
approved these changes
Nov 19, 2024
| '') | ||
| + '' | ||
| # bundle the `mupdf` module provided by mupdf-cxx | ||
| cp -r ${lib.getLib mupdf-cxx}/${python.sitePackages}/mupdf $out/${python.sitePackages}/mupdf |
There was a problem hiding this comment.
Could also use ln -s to save space.
|
I don't see why this is any better than #334596. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the
mupdfPython module which is imported by thepymupdfmodule is present, without relying on propagatedBuildInputs (which is also currently broken, see fix in #334596). This enables compatibility with e.g. uv2nix / pyproject.nix and is more similar to the way the upstream PyPI package works.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.