Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appflowy: 0.7.1 -> 0.8.2 #351509

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

appflowy: 0.7.1 -> 0.8.2 #351509

wants to merge 10 commits into from

Conversation

DarkOnion0
Copy link
Contributor

@DarkOnion0 DarkOnion0 commented Oct 26, 2024 •
edited
Loading

Update appflowy to the latest version

Fix #370928

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DarkOnion0 DarkOnion0 force-pushed the appflowy branch 2 times, most recently from d6ae153 to dccfc28 Compare November 2, 2024 14:49
@DarkOnion0 DarkOnion0 marked this pull request as ready for review November 3, 2024 09:03
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@DarkOnion0 DarkOnion0 marked this pull request as draft November 13, 2024 11:04
@DarkOnion0 DarkOnion0 changed the title appflowy: 0.7.1 -> 0.7.2 appflowy: 0.7.1 -> 0.7.3 Nov 13, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 13, 2024
@DarkOnion0 DarkOnion0 force-pushed the appflowy branch 2 times, most recently from 691857b to cd420b9 Compare November 20, 2024 19:36
@DarkOnion0 DarkOnion0 changed the title appflowy: 0.7.1 -> 0.7.3 appflowy: 0.7.1 -> 0.7.4 Nov 20, 2024
@DarkOnion0 DarkOnion0 marked this pull request as ready for review November 24, 2024 09:35
evris99
evris99 reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@evris99 evris99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes to update appflowy to the latest version.

pkgs/by-name/ap/appflowy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/appflowy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/appflowy/package.nix Outdated Show resolved Hide resolved
@evris99
Copy link
Contributor

evris99 commented Dec 12, 2024

Also you can add me as a maintainer if you like since I'm interested in keeping Appflowy up to date.

@DarkOnion0
Copy link
Contributor Author

DarkOnion0 commented Dec 13, 2024 •
edited
Loading

Hi, thanks a lot for your contribution ! I am more than happy to hear that you're willing to get involved in maintaining appflowy, and I would like to add you as an extra maintainer. However, I couldn't find you in the maintainer list. Moreover, I think that it would be better (regarding what I've grasped of the nixpkgs workflow) for you to create a separated PR for that purpose !

@DarkOnion0 @evris99
appflowy: 0.7.4 -> 0.7.7
8dfcbbd 
https://github.com/AppFlowy-IO/AppFlowy/releases/tag/0.7.7

Co-authored-by: evris <32963606+evris99@users.noreply.github.com>
@DarkOnion0 DarkOnion0 changed the title appflowy: 0.7.1 -> 0.7.7 appflowy: 0.7.1 -> 0.7.8 Dec 21, 2024
@DarkOnion0 DarkOnion0 marked this pull request as ready for review December 21, 2024 10:24
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4996

@DarkOnion0 DarkOnion0 changed the title appflowy: 0.7.1 -> 0.7.8 appflowy: 0.7.1 -> 0.7.9 Dec 31, 2024
@DarkOnion0 DarkOnion0 marked this pull request as draft December 31, 2024 18:45
@jennydaman jennydaman mentioned this pull request Jan 4, 2025
Open
1 task
@DarkOnion0 DarkOnion0 changed the title appflowy: 0.7.1 -> 0.7.9 appflowy: 0.7.1 -> 0.8.0 Jan 7, 2025
@DarkOnion0 DarkOnion0 marked this pull request as ready for review January 8, 2025 14:25
@DarkOnion0 DarkOnion0 changed the title appflowy: 0.7.1 -> 0.8.0 appflowy: 0.7.1 -> 0.8.1 Jan 17, 2025
@bbigras
Copy link
Contributor

bbigras commented Jan 25, 2025

v0.8.2 is out.

@DarkOnion0 DarkOnion0 changed the title appflowy: 0.7.1 -> 0.8.1 appflowy: 0.7.1 -> 0.8.2 Jan 25, 2025
@bbigras
Copy link
Contributor

bbigras commented Jan 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351509

x86_64-linux

✅ 1 package built:
  • appflowy

@DarkOnion0 DarkOnion0 added 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evris99 evris99 evris99 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: appflowy 0.7.1 → 0.7.9
5 participants
@DarkOnion0 @evris99 @nixos-discourse @bbigras @wegank