Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swig: 4.2.1 -> 4.3.0 #350118

Merged
merged 1 commit into from
Nov 18, 2024
Merged

swig: 4.2.1 -> 4.3.0 #350118

merged 1 commit into from
Nov 18, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/swig/versions.

meta.description for swig is: Interface compiler that connects C/C++ code to higher-level languages

meta.homepage for swig is: https://swig.org/

meta.changelog for swig is: https://github.com/swig/swig/blob/v4.3.0/CHANGES.current

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 4.3.0 with grep in /nix/store/3gb18gy1bpfirf9ry5if2xv6xficip7m-swig-4.3.0
  • found 4.3.0 in filename of file in /nix/store/3gb18gy1bpfirf9ry5if2xv6xficip7m-swig-4.3.0

Rebuild report (if merged into master) (click to expand)
56658 total rebuild path(s)

56657 package rebuild(s)

First fifty rebuilds by attrpath

ArchiSteamFarm
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
CuboCore.libcsys
DisnixWebService
Fabric
LAStools
LPCNet
MMA
OVMF
OVMF-cloud-hypervisor
OVMFFull
QuadProgpp
R
SDL
SDL1
SDL2
SDL2_Pango
SDL2_gfx
SDL2_image
SDL2_image_2_0
SDL2_image_2_6
SDL2_mixer
SDL2_mixer_2_0
SDL2_net
SDL2_sound
SDL2_ttf
SDL_Pango
SDL_audiolib
SDL_compat
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/3gb18gy1bpfirf9ry5if2xv6xficip7m-swig-4.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A swig https://github.com/r-ryantm/nixpkgs/archive/bd565dc53d4b16def65154d7beb2635cb63294bd.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/bd565dc53d4b16def65154d7beb2635cb63294bd#swig

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/3gb18gy1bpfirf9ry5if2xv6xficip7m-swig-4.3.0
ls -la /nix/store/3gb18gy1bpfirf9ry5if2xv6xficip7m-swig-4.3.0/bin


Pre-merge build results

NixPkgs review skipped


Maintainer pings

cc @orivej for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The changes proposed in this PR build on a local master branch on aarch64-darwin and produce a usage version of swig.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 22, 2024
@bcdarwin
Copy link
Member

@emilazy

Note after this lands it will also be possible to remove the overridden version of swig in itk.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say no more!

(I’ll try to remember to open a PR for that in the next couple days if you don’t beat me to it.)

@emilazy emilazy merged commit 7b1064c into NixOS:staging Nov 18, 2024
33 checks passed
@r-ryantm r-ryantm deleted the auto-update/swig branch November 19, 2024 00:17
@trofi
Copy link
Contributor

trofi commented Nov 19, 2024

Bisect claims that bd565dc swig: 4.2.1 -> 4.3.0 broke libselinux build in staging on x86_64-linux (a popular dependency) as:

$ nix build --no-link -f. libselinux -L
...
libselinux> selinuxswig_python_wrap.c: In function ‘_wrap_security_compute_user’:
libselinux> selinuxswig_python_wrap.c:11504:17: error: too few arguments to function ‘SWIG_Python_AppendOutput’
libselinux> 11504 |     resultobj = SWIG_Python_AppendOutput(resultobj, plist);
libselinux>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~
libselinux> selinuxswig_python_wrap.c:1259:1: note: declared here
libselinux>  1259 | SWIG_Python_AppendOutput(PyObject* result, PyObject* obj, int is_void) {
libselinux>       | ^~~~~~~~~~~~~~~~~~~~~~~~

@emilazy
Copy link
Member

emilazy commented Nov 19, 2024

Thanks @trofi! I’ve opened #357297.

@bcdarwin bcdarwin mentioned this pull request Nov 20, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants