python3Packages.elastic-transport: disable async httpbin test #346989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
|
Looks like this needs to go to |
cede0cd to
3da3fab
Compare
The async httbin test requires network access.
3da3fab to
8f41b75
Compare
fabaff
reviewed
Oct 8, 2024
| @@ -77,6 +77,7 @@ buildPythonPackage rec { | |||
| "test_debug_logging_no_body" | |||
| "test_httpbin" | |||
| "test_sniffed_nodes_added_to_pool" | |||
| "test_async_transport_httpbin" | |||
There was a problem hiding this comment.
This test is passing on x86_64 locally for me. On Hydra all archs are passing as well.
There was a problem hiding this comment.
This test accesses httpbin.org on the network, which isn’t okay and would break if Hydra had the sandbox enabled. We already disable test_httpbin, which is the synchronous version of the test.
emilazy
approved these changes
Oct 11, 2024
| @@ -77,6 +77,7 @@ buildPythonPackage rec { | |||
| "test_debug_logging_no_body" | |||
| "test_httpbin" | |||
| "test_sniffed_nodes_added_to_pool" | |||
| "test_async_transport_httpbin" | |||
There was a problem hiding this comment.
This test accesses httpbin.org on the network, which isn’t okay and would break if Hydra had the sandbox enabled. We already disable test_httpbin, which is the synchronous version of the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async httbin test requires network access.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.