stdoutisatty: init at 1.0 #345558
Merged
stdoutisatty: init at 1.0 #345558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homepage: https://github.com/lilydjwg/stdoutisatty It is surprisingly difficult to get consistent, colored outputs in the terminal, especially when commands are piped into a pager. In fact, there is a whole Arch wiki page on related topics: - https://wiki.archlinux.org/title/Color_output_in_console#Reading_from_stdin Among the solutions listed there, `stdoutisatty` is one of the simplest: it hijacks the `isatty` function call used by most apps to determine whether `stdout` is an actual terminal, and always returns `1 (true)`. With this I can simply do: ```bash stdoutisatty tree | less cat flake.lock | stdoutisatty jq | less ... ``` and enjoy my colorful outputs, without figuring out whatever `--color=always` type of flags these cli apps may or may not provide for colored outputs.
NickCao
reviewed
Oct 2, 2024
|
Also, we have faketty for the same purpose: https://github.com/dtolnay/faketty |
Ah, this is awesome! Thank you! And it's Memory Safe (trademark) 😆 So the existence of |
NickCao
reviewed
Oct 5, 2024
|
|
||
| cmakeFlags = [ | ||
| # must specify the full path to `libstdoutisatty.so` in the nix store | ||
| "-DCMAKE_C_FLAGS=-DLIB_FILE='\"${placeholder "out"}/lib/libstdoutisatty.so\"'" |
There was a problem hiding this comment.
Suggested change
| "-DCMAKE_C_FLAGS=-DLIB_FILE='\"${placeholder "out"}/lib/libstdoutisatty.so\"'" | |
| (lib.cmakeFeature "CMAKE_C_FLAGS" "-DLIB_FILE='\"${placeholder "out"}/lib/libstdoutisatty.so\"'") |
There was a problem hiding this comment.
Ah that's much better! Thank you!
The old version may lead to confusing `overrideAttrs` behaviors. See discussions linked in the PR review comments. Co-authored-by: Nick Cao <nickcao@nichi.co>
Co-authored-by: Nick Cao <nickcao@nichi.co>
Co-authored-by: Nick Cao <nickcao@nichi.co>
|
Fixed and squashed some commits (unsquashed: master...7a5f7b9). |
NickCao
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Homepage: https://github.com/lilydjwg/stdoutisatty
It is surprisingly difficult to get consistent, colored outputs in the terminal, especially when commands are piped into a pager. In fact, there is a whole Arch wiki page on related topics:
Among the solutions listed there,
stdoutisattyis one of the simplest: it hijacks theisattyfunction call used by most apps to determine whetherstdoutis an actual terminal, and always returns1 (true). With this I can simply do:... and enjoy my colorful outputs, without figuring out whatever
--color=alwaystype of flags these cli apps may or may not provide for colored outputs. Afaik, there is nothing like this in nixpkgs yet, so I would like to package and maintain it.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.