Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heimdal: 7.8.0-unstable-2023-11-29 -> 7.8.0-unstable-2024-09-10 #345129

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

h7x4
Copy link
Member

@h7x4 h7x4 commented Sep 28, 2024

Description of changes

Includes about a year's worth of changes, seems mostly like bugfixes but more importantly it includes a patch for CVE-2023-36328. Not sure what parts of the project are affected, but it seems we explicitly opt in to building hcrypt "for applications like samba", so I'll assume it to be critical enough to warrant backporting.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@h7x4 h7x4 requested a review from 2xsaiko September 28, 2024 16:07
@h7x4 h7x4 added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Sep 28, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 28, 2024
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not great that the package is overwriting patchPhase

@SuperSandro2000
Copy link
Member

@ofborg build heimdal
@ofborg test heimdal

@h7x4
Copy link
Member Author

h7x4 commented Oct 5, 2024

Not great that the package is overwriting patchPhase

Noted, I'll fix it up in another PR!

@SuperSandro2000 SuperSandro2000 merged commit dc1979b into NixOS:master Oct 6, 2024
39 checks passed
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Successfully created backport PR for release-24.05:

@gshpychka
Copy link
Contributor

Result of nixpkgs-review pr 345129 run on aarch64-darwin 1

5 packages failed to build:
  • heimdal
  • heimdal.dev
  • heimdal.info
  • heimdal.man
  • openvas-smb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants