Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: disable failing network tests #343541

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Sep 21, 2024

https://hydra.nixos.org/build/273305124/nixlog/1

Targetting #343421

Related: #313982

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy merged commit 64efdfc into NixOS:staging-next Sep 21, 2024
34 of 36 checks passed
@fabianhjr
Copy link
Member Author

Hi @aduh95, merging this to have the dependents build/test on hydra for staging-next.

This won't land on the main branch for at least a week so if there is an underlying issue or a better/different approach please send it to staging-next. I am assuming this is related to the flakiness that has been experienced before so chose to disable these tests.

@fabianhjr fabianhjr deleted the disable-nodejs-tests branch September 21, 2024 20:04
@aduh95
Copy link
Contributor

aduh95 commented Sep 22, 2024

The failures for the TLS tests are not network related but OpenSSL related. There are patches for those on the Node.js repo, I'll send a PR to include those patches instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants