-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nushellPlugins.bash_env: init at 0.13.0 #343036
base: master
Are you sure you want to change the base?
Conversation
${resholve.phraseSolution "bash_env" { | ||
scripts = [ "libexec/bash_env" ]; | ||
interpreter = "${bash}/bin/bash"; | ||
inputs = [ | ||
jq | ||
coreutils | ||
]; | ||
keep = { | ||
"source" = [ "$_path" ]; | ||
}; | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping this with PATH would pollute its output, so using resholve instead.
buildInputs = lib.optionals stdenv.isDarwin [ | ||
IOKit | ||
Foundation | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is needed as I don't own a Mac, just copied this from the other plugins.
Thank you for your work. It would be nice to get this PR merged. Btw, there is already version 0.14.1 released. |
Nice! I'll update this in a couple of hours with the newer version |
@Misterio77 judging from the README.md at https://github.com/tesujimath/bash-env-nushell the plugin is deprecated in favor of the nu "module" that is for now provided in the same repo as the plugin. So technically it took long enough for a PR for a package to get merged into nixpkgs that the program that the package was made for got deprecated before the PR was merged which is funny in my opinion. Using the module is as simple as |
I submitted a PR for the Once merged it can be used with the bash-env-nushell (module) to implement a 0.9.1 can't process files that set PATH to something that has no required binaries. But it will work on files like 0.9.2 is coming soon with a fix: #358950 After that a |
Description of changes
Add nu_plugin_bash_env, a plugin that helps with sourcing bash environment files.
This should help with nix-community/home-manager#4313.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.