postgresql: fix regress tests after tzdata update #342026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
We can't use |
This was discussed upstream here: https://postgr.es/m/0a997455-5aba-4cf2-a354-d26d8bcbfae6%40technowledgy.de This will be in the next minor releases, until then apply the patch.
1ef6f48 to
52bb840
Compare
TIL. Much better, thanks. |
alyssais
approved these changes
Sep 15, 2024
Scrumplex
approved these changes
Sep 15, 2024
Ma27
approved these changes
Sep 15, 2024
vcunat
pushed a commit
that referenced
this pull request
Nov 4, 2024
This was discussed upstream here: https://postgr.es/m/0a997455-5aba-4cf2-a354-d26d8bcbfae6%40technowledgy.de This will be in the next minor releases, until then apply the patch. (cherry picked from commit 52bb840) (from PR #342026)
This was referenced Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
postgresqlis currently broken on staging, after the tzdata update (#339913) due to failing regression tests.This was discussed upstream here:
https://postgr.es/m/0a997455-5aba-4cf2-a354-d26d8bcbfae6%40technowledgy.de
This will be in the next minor releases, until then apply the patch. Applying the patch from github via fetchurl is not possible, because the upstream patch includes some doc changes, which cause our build to fail. We could fix that by adding new dependencies to rebuild the docs... but it's easier to just keep the patch in nixpkgs for 1-2 months.
TLDR: The patches have been slightly modified from upstream, removing the docs changes.
@Ma27
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.