Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tacentview: init at 1.0.46 #341239

Merged
merged 14 commits into from
Dec 14, 2024
Merged

tacentview: init at 1.0.46 #341239

merged 14 commits into from
Dec 14, 2024

Conversation

poperigby
Copy link
Contributor

Description of changes

I've added both Tacent View (an application for viewing various image formats), and the library it depends on, Tacent.

Closes #219830

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 12, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 24, 2024
@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Oct 31, 2024
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
r-vdp
r-vdp previously requested changes Nov 1, 2024
@Aleksanaa Aleksanaa dismissed r-vdp’s stale review November 1, 2024 14:44

Not a blocker

Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 341239


x86_64-linux

❌ 2 packages failed to build:
  • tacent
  • tacentview

aarch64-linux

❌ 2 packages failed to build:
  • tacent
  • tacentview

x86_64-darwin


aarch64-darwin

Co-authored-by: Leah Amelia Chen <github@acc.pluie.me>
@github-actions github-actions bot added the 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin label Dec 9, 2024
poperigby and others added 3 commits December 9, 2024 14:35
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
I'll squash this later
@GaetanLepage
Copy link
Contributor

The formatter has been updated today. Maybe try to format with nix run .#nixfmt-rfc-style path/to/file.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 341239


x86_64-linux

❌ 2 packages failed to build:
  • tacent
  • tacentview

aarch64-linux

❌ 2 packages failed to build:
  • tacent
  • tacentview

x86_64-darwin


aarch64-darwin

poperigby and others added 2 commits December 10, 2024 21:29
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the formatting is wrong.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 341239


x86_64-linux

✅ 2 packages built:
  • tacent
  • tacentview

aarch64-linux

❌ 2 packages failed to build:
  • tacent
  • tacentview

x86_64-darwin


aarch64-darwin

@GaetanLepage
Copy link
Contributor

Fails on ARM with:

[8/33] Building CXX object UnitTests/CMakeFiles/UnitTests.dir/Src/UnitTests.cpp.o
FAILED: UnitTests/CMakeFiles/UnitTests.dir/Src/UnitTests.cpp.o
/nix/store/ay4xxbjafns12mn2ilhz4y7d3m3ziwqg-gcc-wrapper-13.3.0/bin/g++ -DCONFIG_RELEASE -DPLATFORM_LINUX -I/build/source/UnitTests/Inc -I/build/source/Modules/Foundation/Inc -I/build/source/Modules/Math/Inc -I/bu>
In file included from /build/source/UnitTests/Src/UnitTests.cpp:20:
/build/source/UnitTests/Src/UnitTests.cpp: In function 'int main(int, char**)':
/build/source/UnitTests/Src/UnitTests.cpp:149:15: error: 'Rule' is not a member of 'tUnitTest'
  149 |         tTest(Rule);
      |               ^~~~
/build/source/UnitTests/Src/UnitTests.h:48:146: note: in definition of macro 'tTest'
   48 | #define tTest(name)  { tUnitTest::rPrintf("\nTesting " #name "\n"); tUnitTest::UnitRequirementNumber = tUnitTest::UnitGoalNumber = 0; tUnitTest::name(); }
      |                                                                                                                                                  ^~~~

Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 341239


x86_64-linux

✅ 2 packages built:
  • tacent
  • tacentview

@GaetanLepage GaetanLepage merged commit 7f49814 into NixOS:master Dec 14, 2024
40 of 41 checks passed
@poperigby poperigby deleted the tacent branch December 14, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tacentview
7 participants