Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/plotinus: fix build #338686

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Aug 31, 2024

Description of changes

  • change tested app from gnome-calculator to gnome-pomodoro as plotinus only works on gtk3 apps
  • change screenshot result to one that shows popup from plotinus instead of preferences window
  • add 2 minute timeouts waiting for windows
  • add 10 minute timeout for full test

Fixes build of nixosTests.plotinus (fails since 2021-09-22):
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.plotinus.x86_64-linux
https://hydra.nixos.org/build/270730586

Log:

machine: waiting for a window to appear
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
(finished: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d', in 0.05 seconds)
...
(finished: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d', in 0.04 seconds)
machine: Last chance to match Preferences on the window list, which currently contains: gnome-calculator, gnome-calculator, YXTrayProxy, IceRootProxy, IceTopWin, IceEdge, Frame, TaskBarFrame, TaskBar, SystemTray, TrayPane, TaskPane, AddressBar, Workspaces,  4 ,  3 ,  2 ,  1 , ShowDesktop, ShowWindowList, IceToolbar, Web browser, xterm, TaskBarMenu, Clock, NET-eth0, NET-eth1, CPU-1, MEM, Frame, Container, Calculator, IceBottom, IceWM 3.6.0 (Linux/x86_64)
cleanup
kill machine (pid 9)

(could not wait for "Preferences" window, because plotinus does not work in gnome-calculator)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- change tested app from gnome-calculator to gnome-pomodoro as plotinus
only works on gtk3 apps
- change screenshot result to one that shows popup from plotinus
instead of preferences window
- add 2 minute timeouts waiting for windows
- add 10 minute timeout for full test
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Aug 31, 2024
@ghpzin
Copy link
Contributor Author

ghpzin commented Aug 31, 2024

@ofborg test plotinus

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 31, 2024
Copy link
Member

@Artturin Artturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@Artturin Artturin merged commit 877838a into NixOS:master Sep 1, 2024
27 of 28 checks passed
@ghpzin ghpzin deleted the nixosTests.plotinus/fix-build branch September 1, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants