Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wl-restart: init at 0.2.0 #337887

Merged
merged 1 commit into from
Aug 31, 2024
Merged

wl-restart: init at 0.2.0 #337887

merged 1 commit into from
Aug 31, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Aug 28, 2024 •
edited by dotlambda
Loading

Description of changes

fixes #337343

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 mentioned this pull request Aug 28, 2024
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4479

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 28, 2024
dotlambda
dotlambda reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run nixfmt.

@Bot-wxt1221
Copy link
Member Author

@dotlambda Done.

@Bot-wxt1221 Bot-wxt1221 requested a review from dotlambda August 29, 2024 03:29
dotlambda
dotlambda requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm repeating myself.

@Bot-wxt1221 Bot-wxt1221 requested a review from dotlambda August 29, 2024 03:43
@Bot-wxt1221
Copy link
Member Author

@dotlambda OK now.

dotlambda
dotlambda reviewed Aug 29, 2024
View reviewed changes
@Bot-wxt1221
Copy link
Member Author

@dotlambda done.

@s0me1newithhand7s
Copy link
Contributor

Result of nixpkgs-review pr 337887 run on x86_64-linux 1

1 package built:
  • wl-restart

s0me1newithhand7s
s0me1newithhand7s approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@s0me1newithhand7s s0me1newithhand7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 31, 2024
@Bot-wxt1221 Bot-wxt1221 requested a review from dotlambda August 31, 2024 09:18
@dotlambda dotlambda merged commit d5cbc4d into NixOS:master Aug 31, 2024
26 of 27 checks passed
@Bot-wxt1221 Bot-wxt1221 deleted the wl-restart branch August 31, 2024 14:18
@Bot-wxt1221 Bot-wxt1221 mentioned this pull request Sep 2, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@s0me1newithhand7s s0me1newithhand7s s0me1newithhand7s approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: wl-restart
5 participants
@Bot-wxt1221 @nixos-discourse @s0me1newithhand7s @dotlambda @wegank