Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjodycode: fix on darwin by adding fixDarwinDylibNames #336534

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

donn
Copy link
Member

@donn donn commented Aug 22, 2024

Packages dependent on libjodycode on macOS (read: jdupes) fail to launch because the dylib generated does not set an absolute install path. fixDarwinDylibNames rectifies this.

Description of changes

Added fixDarwinDylibNames to nativeBuildInputs on Darwin hosts.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@donn donn force-pushed the libjodycode_fix branch from 2538157 to c2f111d Compare August 22, 2024 13:11
@donn donn changed the title Fix libjodycode on Darwin libjodycode: fix on darwin Aug 22, 2024
@donn donn changed the title libjodycode: fix on darwin libjodycode: fix on darwin by adding fixDarwinDylibNames Aug 22, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 22, 2024
@donn donn force-pushed the libjodycode_fix branch 2 times, most recently from 7e75181 to edb671a Compare August 27, 2024 17:03
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 27, 2024
@pbsds
Copy link
Member

pbsds commented Aug 29, 2024

Huh, I did not get pinged for this pr, ofborg moment

@donn donn force-pushed the libjodycode_fix branch 2 times, most recently from 728e04a to 89fd8d9 Compare August 29, 2024 09:39
@donn donn requested review from pbsds and Pandapip1 August 29, 2024 09:40
Packages dependent on `libjodycode` on macOS (read: `jdupes`) fail to launch because the dylib generated does not set an absolute install path. `fixDarwinDylibNames` rectifies this.
@donn donn force-pushed the libjodycode_fix branch from 89fd8d9 to bf7d185 Compare August 29, 2024 09:40
@donn
Copy link
Member Author

donn commented Aug 29, 2024

For my own future reference, is there any quick way to test meta? nix build doesn't and I've had to wait for ofborg a couple times now

Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandapip1 Pandapip1 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 29, 2024
@pbsds
Copy link
Member

pbsds commented Aug 29, 2024

i usually just nix eval .#some-package.meta --json

@pbsds pbsds merged commit 49ca403 into NixOS:master Aug 29, 2024
28 of 30 checks passed
@pbsds
Copy link
Member

pbsds commented Aug 29, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants