Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wechat-uos: fix crashing issue caused by zerocallusedregs hardening #335658

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

xddxdd
Copy link
Member

@xddxdd xddxdd commented Aug 18, 2024

Description of changes

The hardening flag zerocallusedregs enabled by default in #316761 caused incompatibility with WeChat's binary file. WeChat would crash in a series of pthread calls.

Overriding the glibc in the FHS with one compiled without the zerocallusedregs fixes the issue.

Immense thanks to @Cryolitia for spending a ton of compute resources and time on bisecting the issue.

Fixes #327860

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

test on x86_64-linux

@Cryolitia Cryolitia added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 18, 2024
@Cryolitia Cryolitia requested a review from UlyssesZh August 18, 2024 18:59
Copy link
Member

@UlyssesZh UlyssesZh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, and also thank @Cryolitia for finding out the cause of the problem.

@ofborg ofborg bot requested a review from pokon548 August 18, 2024 20:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 18, 2024
@pokon548 pokon548 added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Aug 19, 2024
@Cryolitia Cryolitia added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Aug 19, 2024
@Cryolitia Cryolitia requested a review from Aleksanaa August 19, 2024 08:06
@Aleksanaa Aleksanaa merged commit dacbc70 into NixOS:master Aug 19, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wechat-uos: cannot launch: Segmentation fault
5 participants