Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide/nixos: remove with lib; part 3 #335623

Merged
merged 130 commits into from
Nov 29, 2024
Merged

treewide/nixos: remove with lib; part 3 #335623

merged 130 commits into from
Nov 29, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Aug 18, 2024 •
edited
Loading

Description of changes

part of #208242

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd labels Aug 18, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-3 branch from b00f6d9 to 6412e0b Compare August 18, 2024 14:42
@Stunkymonkey Stunkymonkey changed the title Treewide nixos remove with lib 3 treewide/nixos: remove with lib; part 3 Aug 18, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-3 branch 11 times, most recently from 19b42fc to 8ac0216 Compare August 18, 2024 15:24
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 18, 2024
@philiptaron philiptaron self-requested a review August 19, 2024 19:34
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-3 branch 3 times, most recently from 4341673 to 3250550 Compare August 27, 2024 17:36
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 27, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-3 branch from 3250550 to c022b7b Compare August 29, 2024 22:50
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 29, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-3 branch 4 times, most recently from 1b2289a to 6b8fd89 Compare September 2, 2024 20:39
@Stunkymonkey
nixos/services.riemann-tools: remove with lib;
36b176c
@Stunkymonkey
nixos/services.riemann: remove with lib;
a7f9173
@Stunkymonkey
nixos/services.scollector: remove with lib;
b3796ed
@Stunkymonkey
nixos/services.smartd: remove with lib;
084011a
@Stunkymonkey
nixos/services.statsd: remove with lib;
8b8b523
@Stunkymonkey
nixos/services.sysstat: remove with lib;
8eb355e
@Stunkymonkey
nixos/services.telegraf: remove with lib;
851d233
@Stunkymonkey
nixos/services.tremor-rs: remove with lib;
307f280
@Stunkymonkey
nixos/services.tuptime: remove with lib;
6974870
@Stunkymonkey
nixos/services.uptime-kuma: remove with lib;
cc88c36
@Stunkymonkey
nixos/services.vnstat: remove with lib;
e8e5c6c
@Stunkymonkey
nixos/services.watchdogd: remove with lib;
5f44bea
@Stunkymonkey
nixos/services.cachefilesd: remove with lib;
a9748cc
@Stunkymonkey
nixos/services.diod: remove with lib;
4498566
@Stunkymonkey
nixos/services.drbd: remove with lib;
4dbf3a7
@Stunkymonkey
nixos/services.glusterfs: remove with lib;
e4ffb75
@Stunkymonkey
nixos/services.ncdns: remove with lib;
e14d1dc
@Stunkymonkey
nixos/services.nebula: remove with lib;
83cc2cd
@Stunkymonkey
nixos/networking.nftables: remove with lib;
2bf4393
@Stunkymonkey
nixos/services.nylon: remove with lib;
2d4a4c1
@Stunkymonkey
nixos/services.oink: remove with lib;
93d6b81
@Stunkymonkey
nixos/services.stunnel: remove with lib;
07894f4
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-3 branch from 08c5ae0 to 07894f4 Compare November 28, 2024 18:08
@Ma27 Ma27 removed their request for review November 29, 2024 15:00
@Ma27 Ma27 dismissed their stale review November 29, 2024 15:01

My concerns for QA seem to have been addressed, hence withdrawing the request for changes.

@philiptaron
Copy link
Contributor

Let's ship it and see what shakes out.

@philiptaron philiptaron merged commit a403221 into NixOS:master Nov 29, 2024
31 checks passed
@pedorich-n pedorich-n mentioned this pull request Nov 30, 2024
Merged
13 tasks
@philiptaron
Copy link
Contributor

2 days later and no error reports, just a rebase ping. Way to go Felix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

@Ma27 Ma27 Ma27 left review comments

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stunkymonkey @philiptaron @Ma27 @wegank