-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crabfit-api: fix Rust 1.80.0 build regression #335472
crabfit-api: fix Rust 1.80.0 build regression #335472
Conversation
Why are so many crates being updated, not just time? |
This package has no maintainer — are you interested? |
When I attempted
I don't personally use this package, so I don't feel that I'd adequately maintain the package. |
Does |
72b875c
to
0695af0
Compare
I had to relax the dependency on # Modify api/common/Cargo.toml to relax the dependency on chrono, then...
cargo update chrono
cargo update time@0.1.45 --precise 0.3.36 |
There shouldn't be any need to update time 0.1.x — it's only 0.3.x that has the build failure. |
Tracking: NixOS#332957 Upstream issue: GRA0007/crab.fit#340 Upstream patch: GRA0007/crab.fit#341
0695af0
to
f527ee5
Compare
Good catch. This PR now just bumps their copy of 0.3 |
It still seems a bit strange to me that so many dependencies need to be updated? What command did you run to generate this lockfile? |
I used this command: cargo update time@0.3.26 --precise 0.3.36
# Note: 0.3.36 was the latest at the time of this PR |
Description of changes
Tracking: #332957
Upstream issue: GRA0007/crab.fit#340
Upstream patch: GRA0007/crab.fit#341
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.