Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bandwhich: 0.22.2 -> 0.22.2-unstable-2024-08-13" #335092

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 16, 2024

This reverts commit f0c5d2f.

Turns out that this package has been already fixed in #334824

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit f0c5d2f.

Turns out that this package has been already fixed in NixOS#334824
@dotlambda dotlambda merged commit 7e0b24f into NixOS:master Aug 16, 2024
8 of 9 checks passed
@Mic92 Mic92 deleted the bandwhich branch August 16, 2024 11:31
@alyssais
Copy link
Member

Oops.

@Mic92 Mic92 restored the bandwhich branch August 17, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants