Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustlings: init at 6.2.0 #334610

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

luftmensch-luftmensch
Copy link
Contributor

Description of changes

Closes #334595

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aos
Copy link
Member

aos commented Aug 14, 2024

Hmm... looks like rustlings needs cargo (and rust obviously). Should that be included as part of this package?

[nix-shell:~/.cache/nixpkgs-review/pr-334610-1]$ rustlings init
Error: Initialization failed

Caused by:
    0: Failed to run the command `cargo locate-project …`
       Did you already install Rust?
       Try running `cargo --version` to diagnose the problem.
    1: No such file or directory (os error 2)

@luftmensch-luftmensch
Copy link
Contributor Author

@aos Made some changes to make package work properly

@luftmensch-luftmensch
Copy link
Contributor Author

@Atemu Moved all buildInputs into postFixup phase using --suffix flag

Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

I don't know how I would test this. Could you explain a little what QA you have done? I want to be reasonably sure that this actually works as expected.

@luftmensch-luftmensch
Copy link
Contributor Author

Following these steps:

  1. rustlings init
  2. cd rustlings
  3. rustlings (interactive tutorials)

@Atemu
Copy link
Member

Atemu commented Aug 18, 2024

And I assume the tutorials work as expected?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 20, 2024
@Pandapip1
Copy link
Contributor

Result of nixpkgs-review pr 334610 run on x86_64-linux 1

1 package built:
  • rustlings

Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic functionality tested; works.

@Atemu Atemu merged commit ff4a5fc into NixOS:master Aug 29, 2024
24 of 26 checks passed
@luftmensch-luftmensch luftmensch-luftmensch deleted the rustlings_6.2.0 branch August 29, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: rustlings
5 participants