-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustlings: init at 6.2.0 #334610
rustlings: init at 6.2.0 #334610
Conversation
Hmm... looks like
|
9377448
to
0cc4950
Compare
@aos Made some changes to make package work properly |
0cc4950
to
a72ddbf
Compare
a72ddbf
to
c3cb290
Compare
@Atemu Moved all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM.
I don't know how I would test this. Could you explain a little what QA you have done? I want to be reasonably sure that this actually works as expected.
Following these steps:
|
And I assume the tutorials work as expected? |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic functionality tested; works.
c3cb290
to
bc9cbcd
Compare
Description of changes
Closes #334595
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.