Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossip: 0.9 -> 0.11.3 #334369

Merged
merged 3 commits into from
Aug 14, 2024
Merged

gossip: 0.9 -> 0.11.3 #334369

merged 3 commits into from
Aug 14, 2024

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Aug 13, 2024

Description of changes

Obligatory: #327063
Reference: #332957

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft
Copy link
Contributor

msanft commented Aug 13, 2024

Thank you @a-kenji!

I was actually in the process of doing the exact same update for #332957, so let's merge some of the updates I did on my branch into this

Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this also requires libdrm and libffi to be present at runtime now, but since I didn't build on the exact same patch version, it might not anymore. Since it builds, I consider it to be fine.

pkgs/by-name/go/gossip/package.nix Outdated Show resolved Hide resolved
Co-authored-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
@a-kenji
Copy link
Contributor Author

a-kenji commented Aug 13, 2024

I thought this also requires libdrm and libffi to be present at runtime now, but since I didn't build on the exact same patch version, it might not anymore. Since it builds, I consider it to be fine.

This might still be the case. I just tested starting gossip and creating an account, not more functionality beyond that.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@ofborg ofborg bot requested a review from msanft August 13, 2024 14:01
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might still be the case. I just tested starting gossip and creating an account, not more functionality beyond that.

Basic video functionality seems fine. No need to change something unless we notice a feature that doesn't work, imo.

@ofborg ofborg bot requested a review from msanft August 13, 2024 14:37
@alyssais alyssais merged commit 4f18893 into NixOS:master Aug 14, 2024
25 of 26 checks passed
@a-kenji a-kenji deleted the update-gossip branch August 14, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants