-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gossip: 0.9 -> 0.11.3 #334369
gossip: 0.9 -> 0.11.3 #334369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this also requires libdrm
and libffi
to be present at runtime now, but since I didn't build on the exact same patch version, it might not anymore. Since it builds, I consider it to be fine.
Co-authored-by: Moritz Sanft <58110325+msanft@users.noreply.github.com>
This might still be the case. I just tested starting gossip and creating an account, not more functionality beyond that. |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might still be the case. I just tested starting gossip and creating an account, not more functionality beyond that.
Basic video functionality seems fine. No need to change something unless we notice a feature that doesn't work, imo.
Description of changes
Obligatory: #327063
Reference: #332957
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.