-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup: 1.26.0 -> 1.27.1 #332809
rustup: 1.26.0 -> 1.27.1 #332809
Conversation
This used to have git dependencies, but no longer does. Fixes: 26f5d6f ("rustup: 1.25.2 -> 1.26.0")
Bisected the build failure on x86_64-linux to rust-lang/rustup#3340. |
Maybe we should just manually bump |
Okay, actually this should be pretty easy to get working. Pushed a WIP that should be enough to pass tests on |
Tests that only fail on
Tests that only fail on
All tests pass on I have no clue why the Darwin failure sets are disjoint. Tightening the sandbox on |
Failures on
None of this makes much sense. Nondeterminism? Perhaps we really do need to skip tests on Darwin, after all. |
Yeah, running again on
I’ll just disable tests again on Darwin. |
Required to build with Rust 1.80. Link: rust-lang/rust#127343
Let’s land this; it should hopefully be a simple version bump and can’t be more broken than |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/why-is-rustup-1-26-the-newest-available-version-of-rustup/50605/2 |
Description of changes
Required to build with Rust 1.80.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.