Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 24.05] nixfmt-rfc-style updates #327693

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 16, 2024

Description of changes

This PR backports these three PRs:

These updates contain only bug-fixes.

Ping @NixOS/nix-formatting for review/merge

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This work is sponsored by Antithesis

Add a 👍 reaction to pull requests you find important.

djacu and others added 3 commits July 16, 2024 18:18
@infinisil
Copy link
Member Author

CI failure can be ignored. It occurs because I integrated 755b915 into one of the cherry-picked commits.

@ofborg ofborg bot requested review from tomberek, dasJ, piegamesde and 0x4A6F July 16, 2024 18:04
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 16, 2024
@dasJ dasJ merged commit d38b156 into NixOS:release-24.05 Jul 17, 2024
30 of 33 checks passed
@infinisil infinisil deleted the backport-nixfmt-updates branch July 19, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants