kicad: pin to python 3.11 #325726
kicad: pin to python 3.11 #325726
Conversation
There was a problem hiding this comment.
Thanks! Pinning to python 3.11 sounds like the right thing to do.
A couple of notes:
- Your PR description is great, but the commit message is too terse.
- I like to write this so there's a single place where we're switching from python3 to python311. Idea: add a
python3 = python311in the let block at the too of this file. Also a a quick code comment linking to the upstream issue you mentioned: Replace distutils with setuptools wxWidgets/Phoenix#2104
|
@jfly Thank you for your suggestions, I have implemented them. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
I also prefer this commit. I'll go ahead and close mine. Great work! |
|
Is there any fix for the time being before this gets merged? |
|
You can use kicad from nixos-24.05. For example this way. Or just run |
|
@wentasah sadly I dont have flakes setup, thank your for your help though! |
Non-Flakes equivalent would be |
KiCAD depends on wxWidgets, which still uses distutils (removed in Python 3.12)
|
I would have merged this immediately after a friend made me aware of the kicad build issue but since it doesn't eval, I first pushed a fix for that. |
adda30e to
6cec87c
Compare
|
@ofborg eval |
Description of changes
Similar to #325682 , this PR pins the Python version used by
kicadto Python 3.11.KiCAD depends on wxWidgets, which still uses
distutils(removed in Python 3.12), see also wxWidgets/Phoenix#2104 .Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.