Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brainflow: init at 5.12.1 #324462

Merged
merged 2 commits into from
Jul 17, 2024
Merged

brainflow: init at 5.12.1 #324462

merged 2 commits into from
Jul 17, 2024

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Jul 4, 2024 •
edited
Loading

Description of changes

Continuation of #303718, since I goofed up my rebase command and pinged like 100 people. Sorry :(

Closes #278412 (supersedes)

Closes #303517

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 mentioned this pull request Jul 4, 2024
Closed
13 tasks
@Pandapip1 Pandapip1 force-pushed the init-brainflow branch 2 times, most recently from ca7bf96 to 9786a16 Compare July 4, 2024 03:13
@Pandapip1 Pandapip1 requested a review from natsukium as a code owner July 4, 2024 03:13
@Pandapip1
Copy link
Contributor Author

CC @kirillrdy

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 4, 2024
@ofborg ofborg bot requested a review from ziguana July 4, 2024 03:57
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 4, 2024
@Pandapip1 Pandapip1 force-pushed the init-brainflow branch 2 times, most recently from b73e8f7 to 37a91fd Compare July 6, 2024 15:28
@Pandapip1 Pandapip1 requested a review from kirillrdy July 6, 2024 15:29
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 17, 2024
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 324462 run on x86_64-linux 1

5 packages built:
  • brainflow
  • python311Packages.brainflow
  • python311Packages.brainflow.dist
  • python312Packages.brainflow
  • python312Packages.brainflow.dist

@JohnRTitor JohnRTitor merged commit 3dfa73e into NixOS:master Jul 17, 2024
27 checks passed
@Pandapip1 Pandapip1 deleted the init-brainflow branch July 17, 2024 20:51
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jul 17, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor left review comments

@kirillrdy kirillrdy kirillrdy approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@ziguana ziguana Awaiting requested review from ziguana

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: python311Packages.brainflow
4 participants
@Pandapip1 @JohnRTitor @kirillrdy @wegank