j4-dmenu-desktop: unstable-2023-09-12 -> r3.2

[benjamb]

Description of changes

• Upgrade to 3.2
• Add fmt dependency
• Add spdlog dependency
• Switch to meson build system.

Upstream changelog: https://github.com/enkore/j4-dmenu-desktop/blob/r3.2/CHANGELOG
Changes since unstable revision: enkore/j4-dmenu-desktop@7e3fd04...r3.2

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[benjamb]

@ericsagnes You're marked as a maintainer of this package, could I please get a review?

[hakan-demirli]

This PR also solves the memory hogging/leak problem of j4. I observe increasing RAM usage over time. j4 process left in the background after a program is launched. This is after 6 hours, 1.3 GB of RAM usage. It also uses a constant but low amount of CPU.

[meator]

Hey, I'm the main dev behind the r3.0 and r3.1 releases of j4-dmenu-desktop. I have reviewed this PR and it looks like it works well. I would have strongly preferred using the newly introduced Meson build system instead of CMake as noted in BUILDING.md, but both build systems should be fully functional.

[benjamb]

I would have strongly preferred using the newly introduced Meson build system instead of CMake as noted in BUILDING.md, but both build systems should be fully functional.

I could look into doing this as a follow up PR. I'm hesitant to make any more changes to this PR, I don't wish to further delay getting it merged.

[meator]

There appears to be a merge conflict between this PR and master (although I've tried to apply this PR in my clone and no merge conflict has occurred, maybe this PR is just too old and in need of a rebase).

I have also released a new version of j4-dmenu-desktop, r3.2

[benjamb]

@meator I've updated to 3.2 and switched to meson.

[meator]

I have reviewed and tested this update and it looks OK.