ebpf-exporter: init at 2.4.1 and add module #301253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of |
Sigmanificient
suggested changes
Apr 3, 2024
0d9f010 to
39d9b8a
Compare
|
A module (and ideally a test) for that would be nice. |
5ee60c0 to
d4b2e0d
Compare
|
@Ma27 Should be good to go now. |
4b1b145 to
3162f60
Compare
4f28a4a to
859e6ca
Compare
Ma27
reviewed
Jun 29, 2024
| vendorHash = "sha256-2PokkJjsDKdM6QZq/qbZ9DOeeIWUsTbShmnop70xJhM="; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace examples/Makefile \ |
There was a problem hiding this comment.
Why exactly are examples compiled in?
There was a problem hiding this comment.
Because these are the BPF programs which make the exporter useful.
859e6ca to
51f30d6
Compare
LostAttractor
suggested changes
Aug 6, 2024
There was a problem hiding this comment.
Can't build on latest nixpkgs since #316761 get merged.
clang: error: unsupported option '-fzero-call-used-regs=used-gpr' for target 'bpf'
zerocallusedregs is not available for bpf target
It should be disabled by adding hardeningDisable = [ "zerocallusedregs" ];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds https://github.com/cloudflare/ebpf_exporter at 2.4.1, tested with biolatency eBPF program from upstream.
Also adds a module for the exporter.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.