-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/gnome-remote-desktop: add package to environment.systemPackages… #301246
Conversation
|
||
systemd.packages = [ pkgs.gnome.gnome-remote-desktop ]; | ||
systemd.tmpfiles.packages = [ pkgs.gnome.gnome-remote-desktop ]; | ||
|
||
users = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I thought it would be automatically set up but looks like it is still experimental in NixOS and disabled by default:
Note: This is experimental. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, I didn't even know that NixOS even had that feature! Would you recommend that I swap out the manual user and group creation for systemd.sysusers.enable = true
?
EDIT: Absolutely nevermind. I just experienced the scariest thing known to man after enabling systemd.sysusers
while having mutableUsers disabled. All of my users were rendered useless and I couldn't login to any of them. Thank every god known to mankind for Nix generations. I should've listened when I heard it was experimental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should user creation be conditional based on sysusers
being enabled? Do we do that anywhere right now - and should we? Afaict we only have a comment next to flatpak to switch to sysusers at some point when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you recommend that I swap out the manual user and group creation for
systemd.sysusers.enable = true
?
Yeah, that could have unintended side-effects, as you found out. Stuff like this is usually better enabled top-down, rather than bottom up.
Should user creation be conditional based on
sysusers
being enabled? Do we do that anywhere right now - and should we?
Not sure how it behaves when there are conflicts between sysusers
and users.users
. It might be a good idea to test it for future-proofing once the sysusers.nix
functionality is enabled but not critical at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looking at the sysuser.nix
that just makes it so users.users
users are created using sysusers.d
– the systemd functionality should already be enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that has any effect beyond being built with necessary support, same as homed support always being compiled in but not on by default - but I'd prefer if maybe someone who maintains systemd in nix could weigh in.
Maybe for now it's enough to just add a comment in the module saying that the package provides a sysusers.d file we should switch to one day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking a look at this and getting things working.
74938c3
to
42c13b9
Compare
Add package to environment.systemPackages, services.dbus.packages, create gnome-remote-desktop user and group (fixes for GNOME 46) This adds the `g-r-d` package to environment.systemPackages (allowing the usage of the `grdctl` command along with enabling `g-r-d`'s polkit rule), makes its dbus-related files recognizable to dbus, and creates the `gnome-remote-desktop` user and group necessary for systemd's running of the `gnome-remote-desktop-daemon` with the `--system` subcommand and enabling Remote Login.
42c13b9
to
be22f7c
Compare
…, services.dbus.packages, create gnome-remote-desktop user and group (fixes for GNOME 46)
This adds the
g-r-d
package to environment.systemPackages (allowing the usage of thegrdctl
command along with enablingg-r-d
's polkit rule), makes its dbus-related files recognizable to dbus, and creates thegnome-remote-desktop
user and group necessary for systemd's running of thegnome-remote-desktop-daemon
with the--system
subcommand and enabling Remote Login.Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.