vscode-utils: Set the sourceRoot attribute on vscode extensions #289721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some extensions contain directories other than `extension` (e.g., `package`, if the extension has a digital signature). The unpacker phase fails if a .vsix file contains more than one directory at the archive's root and the `sourceRoot` attribute is unset.
1 task
|
It would be very helpful, if this PR is merged. It is breaking my nixos-rebuild due to having lot of VSCode extenstions in my configuration. Thanks for all hard work of the contributors. |
|
Result of 303 packages built:
|
JohnRTitor
approved these changes
Apr 6, 2024
|
Result of 1 package marked as broken and skipped:
4 packages built:
|
superherointj
approved these changes
Apr 11, 2024
|
@superherointj Is it okay for this to be back ported to release-23.11? |
|
Successfully created backport PR for |
Merged
1 task
Noratrieb
added a commit
to Noratrieb/nixos
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extensions for VSCode contain directories other than
extension(e.g.,package, if the extension has a digital signature). The unpacker phase fails if a .vsix file contains more than one directory at the archive's root and thesourceRootattribute is unset.I've recently encountered this issue with
ms-vscode.cmake-tools, which, since 1.17.15, is digitally signed. Others have encountered this issue as well:In particular, nix-community/nix-vscode-extensions#31 suggests setting
sourceRootusingoverrideAttrs. However, since VSCode extensions have a well-defined structure, setting thesourceRootfor all extensions is valid.nix-vscode-extensionsuses the functions invscode-utilsso it will inherit the fix (which I've verified locally).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.