atlantis: 0.22.3 -> 0.27.0

[siddharthdhakane]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jpotier]

nix run https://codeload.github.com/siddharthdhakane/nixpkgs/zip/refs/heads/update-atlantis#atlantis -- version
atlantis 0.27.0 (commit: none) (build date: unknown)

Builds and runs

[thiagokokada]

Can you set using it with Go flags instead?

Suggested change

	patchPhase = ''
	substituteInPlace main.go --replace dev ${version}
	'';
	ldflags = [ "-X=main.version=${version}" ];

(I am not 100% sure if this works in non-public vars, but we should at least try).

BTW, we probably also should set the commit and date (with Unix epoch) flags: https://github.com/runatlantis/atlantis/blob/main/main.go#L30-L32

[thiagokokada]

https://github.com/runatlantis/atlantis/blob/cea2db5fb0690b91f85f5da8cb0113a2cfac0e5c/Dockerfile#L40

It definitely seems to work, so we should use it instead of fragile substituteInPlace hacks.

[illustris]

Adding date will make this impure. Also, fetchFromGithub doesn't give you any information about the commit ID. Hardcoding the commit ID or switching to fetchgit just to add this output to the version subcommand is excessive.

[thiagokokada]

Adding date will make this impure.

This is why I suggested to use the Unix Epoch: https://en.wikipedia.org/wiki/Unix_time, not the actual build time.

Also, fetchFromGithub doesn't give you any information about the commit ID. Hardcoding the commit ID or switching to fetchgit just to add this output to the version subcommand is excessive.

This is fair enough.

[siddharthdhakane]

I've added the date in the RFC3339 format as recommended here.

[thiagokokada]

Result of nixpkgs-review pr 279776 run on aarch64-darwin 1

1 package built:

• atlantis

[illustris]

Suggested change

	date = "1970-01-01T00:00:00Z";
	ldflags = [ "-X=main.version=${version}" "-X=main.date=${date}"];
	ldflags = [
	"-X=main.version=${version}"
	"-X=main.date=1970-01-01T00:00:00Z"
	];

There is no need to add date as an attr to the derivation