Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

himalaya: 0.8.4 -> 1.0.0-beta #278088

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

soywod
Copy link
Contributor

@soywod soywod commented Jan 1, 2024

Description of changes

The new API of the configuration file contains breaking changes, please have a look at the CHANGELOG: https://github.com/soywod/himalaya/releases/tag/v1.0.0-beta.

Since cargo features have been renamed, nix flags also changed:

  • withImapBackend became withImap
  • withNotmuchBackend became withNotmuch
  • withSmtpSender became withSmtp

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@soywod soywod force-pushed the himalaya-v1.0.0-beta branch from c89f745 to 7257ea3 Compare January 1, 2024 16:27
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jan 1, 2024
@ofborg ofborg bot requested review from toastal and yanganto January 1, 2024 17:00
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 1, 2024
@soywod soywod force-pushed the himalaya-v1.0.0-beta branch 2 times, most recently from 45cf0e2 to 998f2b4 Compare January 1, 2024 20:32
Copy link
Contributor

@toastal toastal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds/runs on my machine.

Tangent: sure would be nice if one could approve pull requests via email like you can comments instead of using this godforsaken UI

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 2, 2024
@thiagokokada thiagokokada merged commit f4549e0 into NixOS:master Jan 9, 2024
25 checks passed
@soywod soywod deleted the himalaya-v1.0.0-beta branch January 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants