haskellPackages.{repa,hip}: Apply build fixes #276275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we maybe do this via the "inherit trick" so that Nix does not silently override potential other repa overrides in the file? |
929b2c3 to
1be5659
Compare
Yes, good idea @maralorn. I have updated the patch. |
7a30ce3 to
b55cdff
Compare
|
ping |
|
@domenkozar Who are you pinging and why? |
|
pong 🙂 |
|
I quoted the wrong PR number in the description, that's why. |
Some dependencies of Chart-diagrams have been updated and no longer require Cabal jailbreaks. Of the remaining jailbreaks, I have added links to GitHub issues/PRs, where they exist.
11a7904 to
929d6d0
Compare
|
Cherry-picked onto haskell-updates with some minor changes. |
|
Thanks @sternenseemann 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for merging into #279413, cc @sternenseemann.
Description of changes
One does not simply
import Graphics.Image.Processing.This fixes the build of the
hippackage under ghc94, ghc96, ghc98. Becauserepais a dependency, that also gets a patch so that it builds.Things done
I haven't opened upstream issues/PRs yet.