Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: add libGL.so.1 to vscode executable #272028

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

anilanar
Copy link
Contributor

@anilanar anilanar commented Dec 4, 2023

This should be backported to 23.11.

GPU acceleration broke again for vscode, this time complaining about missing libGL.so.1.

For past issues, see:

#243372
#248200

PRs that fixed those issues, respectively:

#245705
#249853

The same issue fixed for chromium/electron apps and backported, respectively: #269345 #269414

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 4, 2023
@lorenz
Copy link
Contributor

lorenz commented Dec 7, 2023

For me on Wayland this also requires libEGL.so, but with that it works.

@anilanar
Copy link
Contributor Author

anilanar commented Dec 7, 2023

@lorenz Do you mean wayland needs a --add-needed ${libglvnd}/lib/libEGL.so ?

@lorenz
Copy link
Contributor

lorenz commented Dec 7, 2023

Yup, --add-needed ${libglvnd}/lib/libEGL.so.1

Fixes gpu acceleration for X and Wayland.
@anilanar anilanar force-pushed the fix-vscode-gpu-accel-libgl branch from 2f3b663 to fdb1afe Compare December 7, 2023 01:28
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vscode 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants