Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igv: Fix missing wrapGAppsHook causing causing GLib-GIO-ERROR #270229

Merged
merged 1 commit into from
Nov 26, 2023
Merged

igv: Fix missing wrapGAppsHook causing causing GLib-GIO-ERROR #270229

merged 1 commit into from
Nov 26, 2023

Conversation

stianlagstad
Copy link
Contributor

Fixes #270226

Description of changes

Adding wrapGAppsHook so that igv doesn't crash when trying to open files.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

NA

@stianlagstad stianlagstad requested a review from mimame November 26, 2023 19:00
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2023
@NickCao NickCao merged commit 1ed523e into NixOS:master Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

igv: "No GSettings schemas are installed on the system" error when opening file dialog
4 participants