Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.11] haskell.compiler.ghc*: set abs paths for cctools bintools w/ hadrian #269154

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[23.11] haskell.compiler.ghc*: set abs paths for cctools bintools w/ hadrian #269154

merged 1 commit into from
Nov 22, 2023

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Nov 22, 2023 •
edited
Loading

Fixes #267250.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@avdv @sternenseemann
haskell.compiler.ghc*: set abs paths for cctools bintools w/ hadrian
f2c1063 
Fixes NixOS#267250.

Co-authored-by: sternenseemann <sternenseemann@systemli.org>
@sternenseemann sternenseemann changed the title haskell.compiler.ghc*: set abs paths for cctools bintools w/ hadrian [23.11] haskell.compiler.ghc*: set abs paths for cctools bintools w/ hadrian Nov 22, 2023
@sternenseemann sternenseemann mentioned this pull request Nov 22, 2023
Merged
@ofborg ofborg bot requested review from guibou and expipiplus1 November 22, 2023 10:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 22, 2023
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 22, 2023
@sternenseemann sternenseemann merged commit eda04d7 into NixOS:release-23.11 Nov 22, 2023
11 checks passed
@sternenseemann sternenseemann deleted the backport-23.11-ghc-hadrian-cctools branch November 22, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

@ncfavier ncfavier Awaiting requested review from ncfavier ncfavier is a code owner

@guibou guibou Awaiting requested review from guibou

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sternenseemann @cdepillabout @delroth @avdv