-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnquery: init at 9.11.0 #251554
cnquery: init at 9.11.0 #251554
Conversation
Please split your changes into two commits: maintainers: add mariuskimmina |
Result of 1 package failed to build:
|
nixpkgs-review seems to have failed at the hash. Maybe you could redo it? error: hash mismatch in fixed-output derivation '/nix/store/zxpky2jz73wckpzdna41yb4c41r7m541-source.drv':
specified: sha256-vSckQ49Mskqdewi4GcTZGu6069HeTG+A84M2ccsqudg=
got: sha256-cOKZRcwlzznhn31Pz28YrisO12pb9c0ULjTL/mnwOdE=
error: 1 dependencies of derivation '/nix/store/x7m6mlvnadfg9x26rrqk5gr69lcnjy0r-cnquery-8.24.2-go-modules.drv' failed to build |
Locally I first made this package with version |
I believe that's a quite common problem. If nix finds a derivation with the specified hash in your nix store, it just assumes it to be the correct one, without notifying you. The most basic solution is to remove the hash, rebuild, and readd the hash from the error message. I think a nice way to do this is to use |
Done, there are now 2 commits |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package builds, diff looks good, and binary seems to run fine. Nice work!
Anything still needs to be done from my site? New to this process |
Not much unfortunately... Getting stuff merged into nixpkgs can be a bit of a slow process, as there are a lot more PRs than there are reviewers and committers. Although it won't help your PR in particular, you can assist with the general problem by reviewing a few PRs. There's also a few megathreads over at https://discourse.nixos.org where you can ask people to have an extra look. Namely the "PRs ready for review" (make sure to pick the one with the underscore, the other seems dead) and "PRs already reviewed" threads. |
Welcome to nixpkgs! Apologies for the delay on this PR. Would you please update it for the |
c42a625
to
90a8287
Compare
Thank you @emilytrau - now the delay was on my side, I have updated the PR to the latest version, 9.11.0 at this point |
Description of changes
Adding a package for https://github.com/mondoohq/cnquery
Also adding myself as maintainer of the package
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)