Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnquery: init at 9.11.0 #251554

Merged
merged 2 commits into from
Dec 17, 2023
Merged

cnquery: init at 9.11.0 #251554

merged 2 commits into from
Dec 17, 2023

Conversation

mariuskimmina
Copy link
Member

Description of changes

Adding a package for https://github.com/mondoohq/cnquery
Also adding myself as maintainer of the package

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 26, 2023
@h7x4
Copy link
Member

h7x4 commented Aug 27, 2023

Please split your changes into two commits:

maintainers: add mariuskimmina
cnquery: init at 8.24.2

@h7x4
Copy link
Member

h7x4 commented Aug 27, 2023

Result of nixpkgs-review pr 251554 run on x86_64-linux 1

1 package failed to build:
  • cnquery

@h7x4
Copy link
Member

h7x4 commented Aug 27, 2023

nixpkgs-review seems to have failed at the hash. Maybe you could redo it?

error: hash mismatch in fixed-output derivation '/nix/store/zxpky2jz73wckpzdna41yb4c41r7m541-source.drv':
         specified: sha256-vSckQ49Mskqdewi4GcTZGu6069HeTG+A84M2ccsqudg=
            got:    sha256-cOKZRcwlzznhn31Pz28YrisO12pb9c0ULjTL/mnwOdE=
error: 1 dependencies of derivation '/nix/store/x7m6mlvnadfg9x26rrqk5gr69lcnjy0r-cnquery-8.24.2-go-modules.drv' failed to build

@mariuskimmina
Copy link
Member Author

nixpkgs-review seems to have failed at the hash. Maybe you could redo it?

error: hash mismatch in fixed-output derivation '/nix/store/zxpky2jz73wckpzdna41yb4c41r7m541-source.drv':
         specified: sha256-vSckQ49Mskqdewi4GcTZGu6069HeTG+A84M2ccsqudg=
            got:    sha256-cOKZRcwlzznhn31Pz28YrisO12pb9c0ULjTL/mnwOdE=
error: 1 dependencies of derivation '/nix/store/x7m6mlvnadfg9x26rrqk5gr69lcnjy0r-cnquery-8.24.2-go-modules.drv' failed to build

Locally I first made this package with version 8.23.2 instead of 8.24.2 .
When I changed the version I expected the hash to change but somehow nix-build -A cnquery kept working fine so I didn't change it. What should I have done locally to recalculate the hash?

@h7x4
Copy link
Member

h7x4 commented Aug 27, 2023

I believe that's a quite common problem. If nix finds a derivation with the specified hash in your nix store, it just assumes it to be the correct one, without notifying you. The most basic solution is to remove the hash, rebuild, and readd the hash from the error message.

I think a nice way to do this is to use nix-update, which bumps both the version number and hash for you. While some packages require more advanced update scripts, adding passthru.updateScript = nix-update-script { }; is usually fine for most cases. Then you could do nix-update cnquery to update it.

@mariuskimmina
Copy link
Member Author

Please split your changes into two commits:

maintainers: add mariuskimmina cnquery: init at 8.24.2

Done, there are now 2 commits

@h7x4
Copy link
Member

h7x4 commented Aug 27, 2023

Result of nixpkgs-review pr 251554 run on x86_64-linux 1

1 package built:
  • cnquery

Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package builds, diff looks good, and binary seems to run fine. Nice work!

@h7x4 h7x4 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 29, 2023
@mariuskimmina
Copy link
Member Author

Anything still needs to be done from my site? New to this process

@h7x4
Copy link
Member

h7x4 commented Sep 5, 2023

Not much unfortunately...

Getting stuff merged into nixpkgs can be a bit of a slow process, as there are a lot more PRs than there are reviewers and committers. Although it won't help your PR in particular, you can assist with the general problem by reviewing a few PRs.

There's also a few megathreads over at https://discourse.nixos.org where you can ask people to have an extra look. Namely the "PRs ready for review" (make sure to pick the one with the underscore, the other seems dead) and "PRs already reviewed" threads.

@emilytrau
Copy link
Member

Welcome to nixpkgs! Apologies for the delay on this PR. Would you please update it for the 9.9.4 release and I will get it merged ASAP. Thanks for your contribution

@mariuskimmina mariuskimmina changed the title cnquery: init at 8.24.2 cnquery: init at 9.11.0 Dec 13, 2023
@mariuskimmina
Copy link
Member Author

Welcome to nixpkgs! Apologies for the delay on this PR. Would you please update it for the 9.9.4 release and I will get it merged ASAP. Thanks for your contribution

Thank you @emilytrau - now the delay was on my side, I have updated the PR to the latest version, 9.11.0 at this point

@emilytrau emilytrau merged commit f2aff72 into NixOS:master Dec 17, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants