Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bun: 0.6.14 -> 0.7.0 #244746

Merged
merged 3 commits into from
Jul 22, 2023
Merged

bun: 0.6.14 -> 0.7.0 #244746

merged 3 commits into from
Jul 22, 2023

Conversation

cdmistman
Copy link
Contributor

@cdmistman cdmistman commented Jul 22, 2023 •
edited
Loading

Description of changes
  • added myself to maintainers
  • updated bun from 0.6.14 to 0.7.0
  • changed changelog url to use the one from the bun blog eg https://bun.sh/blog/bun-v0.7.0
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@cdmistman cdmistman changed the title Update bun bun: 0.6.14 -> 0.7.0 Jul 22, 2023
@GiggleSquid
Copy link
Contributor

Result of nixpkgs-review pr 244746 run on x86_64-linux 1

1 package built:
  • bun

GiggleSquid
GiggleSquid reviewed Jul 22, 2023
View reviewed changes
Copy link
Contributor

@GiggleSquid GiggleSquid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, lgtm!

I know you've only updated the package and swapped out the changelog. But is there any reason this package uses fetchurl and builds with unzip, rather than just using fetchzip?

Is it for the update script to work?

@cdmistman
Copy link
Contributor Author

I know you've only updated the package and swapped out the changelog. But is there any reason this package uses fetchurl and builds with unzip, rather than just using fetchzip?

Is it for the update script to work?

@DAlperin wrote the initial package in #180299 with fetchurl, but the update script was added #192265. I think it's probably just what Dov was familiar with at the time. Nonetheless, the way the package is written is known to work, so I don't think it's worth rewriting it using fetchzip

@GiggleSquid
Copy link
Contributor

That makes sense. And fair enough, if it ain't broke!

@NickCao NickCao merged commit bf7edba into NixOS:master Jul 22, 2023
@cdmistman cdmistman deleted the update-bun branch July 22, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiggleSquid GiggleSquid GiggleSquid approved these changes

@06kellyjac 06kellyjac Awaiting requested review from 06kellyjac

@DAlperin DAlperin Awaiting requested review from DAlperin

@thilobillerbeck thilobillerbeck Awaiting requested review from thilobillerbeck

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdmistman @GiggleSquid @NickCao