Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-compose: 2.19.1 -> 2.20.2 #244013

Merged
merged 1 commit into from
Jul 21, 2023
Merged

docker-compose: 2.19.1 -> 2.20.2 #244013

merged 1 commit into from
Jul 21, 2023

Conversation

SuperSandro2000
Copy link
Member

Diff: docker/compose@v2.19.1...v2.20.0

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from babariviere July 17, 2023 18:11
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jul 17, 2023
@LeSuisse
Copy link
Member

@SuperSandro2000 Do you mind bumping to the freshly released 2.20.1? It includes a fix for Go 1.20.6 https://github.com/docker/compose/releases/tag/v2.20.1

@LeSuisse LeSuisse mentioned this pull request Jul 19, 2023
Merged
12 tasks
@SuperSandro2000
Copy link
Member Author

sure but as far as I can tell that's just bumping their docker image, so it shouldn't matter to much to us.

@LeSuisse
Copy link
Member

LeSuisse commented Jul 19, 2023 •
edited
Loading

It is not directly listed in the release notes (the PR listed for the Go 1.20.6 support mention it) but it also contains docker/compose@ce8a09b

@SuperSandro2000 SuperSandro2000 changed the title docker-compose: 2.19.1 -> 2.20.0 docker-compose: 2.19.1 -> 2.20.1 Jul 19, 2023
@SuperSandro2000 SuperSandro2000 changed the title docker-compose: 2.19.1 -> 2.20.1 docker-compose: 2.19.1 -> 2.20.2 Jul 19, 2023
@Frostman
Copy link
Member

Result of nixpkgs-review pr 244013 run on x86_64-linux 1

21 packages built:
  • apptainer
  • apptainer-overriden-nixos
  • apx
  • charliecloud
  • docker (docker_20_10)
  • docker-client
  • docker-client.man
  • docker-compose
  • docker-gc
  • docker.man (docker_20_10.man)
  • fn-cli
  • nvidia-docker
  • pipework
  • python310Packages.jupyter-repo2docker
  • python310Packages.jupyter-repo2docker.dist
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

@SuperSandro2000 SuperSandro2000 merged commit eb668d3 into NixOS:master Jul 21, 2023
@SuperSandro2000 SuperSandro2000 deleted the docker-compose branch July 21, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Frostman approved these changes

@babariviere babariviere Awaiting requested review from babariviere

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperSandro2000 @LeSuisse @Frostman