Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bloodhound: init at 4.3.1 #242534

Merged
merged 1 commit into from
Jul 29, 2023
Merged

bloodhound: init at 4.3.1 #242534

merged 1 commit into from
Jul 29, 2023

Conversation

AkechiShiro
Copy link
Contributor

Description of changes

Continuation of #164043, bumped version to 4.3.1 (latest stable release) and rebase on Nixpkgs.

Change maintainer to myself as I'll be using this package, previous maintainer, looked like he was missing and not responding.

This latest stable release is affected by this bug : SpecterOps/BloodHound-Legacy#590
Version 4.2.0 is not affected.

Note
A workaround mentioned here works for 4.3.1 : Automattic/simplenote-electron#3044 (comment), when launching the binary use --in-gpu-process, if it fails use --disable-gpu-sandbox and if all else fails, then use --no-sandbox, these option have negative security impact.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 9, 2023
SuperSandro2000
SuperSandro2000 reviewed Jul 10, 2023
View reviewed changes
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua labels Jul 10, 2023
@drupol drupol marked this pull request as draft July 10, 2023 14:36
@drupol
Copy link
Contributor

drupol commented Jul 10, 2023

Please, rebase your branch on top of latest commit from NixOS/nixpkgs.

@AkechiShiro AkechiShiro force-pushed the new-bloodhound-init branch from 093621e to 539490a Compare July 10, 2023 15:01
@github-actions github-actions bot removed 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation labels Jul 10, 2023
@drupol
Copy link
Contributor

drupol commented Jul 10, 2023

Yes, the PR contains 1 single commit and it's much better ;)

drupol
drupol requested changes Jul 10, 2023
View reviewed changes
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bloodhound/default.nix Show resolved Hide resolved
pkgs/applications/misc/bloodhound/default.nix Outdated Show resolved Hide resolved
@drupol drupol changed the title Bloodhound: init at 4.3.1 bloodhound: init at 4.3.1 Jul 10, 2023
@AkechiShiro AkechiShiro force-pushed the new-bloodhound-init branch from 9e9af10 to eb0228f Compare July 10, 2023 15:49
drupol
drupol requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, could you please adjust the commit log message, it should be the same as the PR title (I modified it).

@AkechiShiro AkechiShiro force-pushed the new-bloodhound-init branch from eb0228f to 5590741 Compare July 10, 2023 17:12
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2446

@drupol
Copy link
Contributor

drupol commented Jul 22, 2023

As long as this PR is in draft, it won't be reviewed. If you think it's ready for ready, remove it from draft.

@AkechiShiro AkechiShiro force-pushed the new-bloodhound-init branch from fc69efe to 4ccc5c6 Compare July 22, 2023 16:59
@AkechiShiro AkechiShiro mentioned this pull request Jul 23, 2023
Closed
13 tasks
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jul 25, 2023
@AkechiShiro AkechiShiro force-pushed the new-bloodhound-init branch 2 times, most recently from 725be97 to 56ed7e9 Compare July 25, 2023 21:05
@AkechiShiro AkechiShiro marked this pull request as ready for review July 25, 2023 21:06
RaitoBezarius
RaitoBezarius requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary provenance should be indicated explicitly.

@AkechiShiro AkechiShiro force-pushed the new-bloodhound-init branch from 56ed7e9 to f6b0f91 Compare July 29, 2023 12:42
@AkechiShiro
bloodhound: init at 4.3.1
edc88c9 
* Use finalAttrs and fetchzip
* Updated gpl3 -> gpl3Plus
* Added meaningful description
* Fix segmentation fault trace traps by needing udev
* Fix Electron sandbox issue with --in-gpu-process
* Add sourceProvenance and changelog to meta
@AkechiShiro AkechiShiro force-pushed the new-bloodhound-init branch from b47fd77 to edc88c9 Compare July 29, 2023 13:52
@RaitoBezarius RaitoBezarius merged commit 678cac4 into NixOS:master Jul 29, 2023
@AkechiShiro AkechiShiro mentioned this pull request Sep 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@drupol drupol drupol approved these changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@aanderse aanderse Awaiting requested review from aanderse

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

@figsoda figsoda Awaiting requested review from figsoda

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AkechiShiro @drupol @nixos-discourse @RaitoBezarius @jtojnar @SuperSandro2000