bitwarden: 2023.4.0 -> 2023.5.0 #235756
Merged
bitwarden: 2023.4.0 -> 2023.5.0 #235756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarshall
approved these changes
Jun 3, 2023
| url = "https://github.com/bitwarden/clients/pull/5205.patch"; | ||
| hash = "sha256-sKSrh8RHXtxGczyZScjTeiGZgTZCQ7f45ULj/j9cp6M="; | ||
| }) | ||
| ]; |
There was a problem hiding this comment.
Can remove the fetchpatch param to the fn now.
There was a problem hiding this comment.
Could get rid of the whole applyPatches layer too, right?
There was a problem hiding this comment.
Yes, though I almost prefer to keep it so it’s a bit easier and more obvious how to add patches in the future. I did open #236370 with the aim of reducing the unnecessary intermediate drv in scenarios like this.
eaed262 to
1111114
Compare
SuperSandro2000
approved these changes
Jun 9, 2023
amarshall
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)