Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphviz: drop libdevil backend #234481

Merged
merged 1 commit into from
May 28, 2023
Merged

graphviz: drop libdevil backend #234481

merged 1 commit into from
May 28, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented May 27, 2023 •
edited
Loading

Description of changes

Seems unmaintained upstream, both the backend and the library, and the feature set is already covered by other backends.

Removes a Mesa dependency, which is especially relevant in light of #233265.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from bjornfor and 7c6f434c May 27, 2023 19:35
bjornfor
bjornfor requested changes May 27, 2023
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should target the staging branch.

@K900 K900 marked this pull request as draft May 28, 2023 05:44
@K900 K900 changed the base branch from master to staging May 28, 2023 05:44
@github-actions github-actions bot added 6.topic: kernel The Linux kernel 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: stdenv Standard environment 6.topic: vim 8.has: module (update) This PR changes an existing module in `nixos/` labels May 28, 2023
@K900
graphviz: drop libdevil backend
dc6fd4b 
Seems unmaintained upstream, both the backend and the library, and
the feature set is already covered by other backends.

Removes a Mesa dependency, which is especially relevant in light of NixOS#233265.
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: kernel The Linux kernel 6.topic: python 6.topic: stdenv Standard environment 6.topic: vim 6.topic: lua labels May 28, 2023
@K900 K900 marked this pull request as ready for review May 28, 2023 05:46
@K900
Copy link
Contributor Author

K900 commented May 28, 2023

Yeah, was waiting for ofborg to get the rebuild count. Retargeted now.

@K900 K900 merged commit 70807a3 into NixOS:staging May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@alyssais alyssais alyssais approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@K900 @bjornfor @alyssais