Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-airflow: 2.5.1 -> 2.6.0, python3Packages.apache-airflow still broken due to sqlalchemy requirements #231944

Closed
wants to merge 5 commits into from

Conversation

graham33
Copy link
Contributor

@graham33 graham33 commented May 14, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@graham33 graham33 changed the title Fix/apache airflow broken apache-airflow: fix, python3Packages.apache-airflow still broken due to sqlalchemy requirements May 14, 2023
@graham33 graham33 requested review from risicle and mweinelt and removed request for risicle May 14, 2023 22:34
@graham33 graham33 changed the title apache-airflow: fix, python3Packages.apache-airflow still broken due to sqlalchemy requirements apache-airflow: 2.5.1 ->2.6.0, python3Packages.apache-airflow still broken due to sqlalchemy requirements May 14, 2023
@graham33 graham33 changed the title apache-airflow: 2.5.1 ->2.6.0, python3Packages.apache-airflow still broken due to sqlalchemy requirements apache-airflow: 2.5.1 -> 2.6.0, python3Packages.apache-airflow still broken due to sqlalchemy requirements May 14, 2023
@mweinelt
Copy link
Member

My opinion is still: airflow shouldnt live in python-modules. Can use its own package overrides then. Can even coerce itself into a library inside its own package set

@risicle
Copy link
Contributor

risicle commented May 15, 2023

@ofborg build pyrosimple

broken by python-daemon bump

@risicle
Copy link
Contributor

risicle commented May 28, 2023

We should probably make a decision about this before the 31st. There are also now 2 CVEs out on airflow < 2.6.0:

@risicle
Copy link
Contributor

risicle commented May 29, 2023

Hope you don't mind I've pushed a fix for pyrosimple to the branch.

@ofborg build pyrosimple

@ofborg ofborg bot requested a review from a user May 29, 2023 11:14
@graham33
Copy link
Contributor Author

graham33 commented Jun 5, 2023

Closing in favour of #235081

@graham33 graham33 closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants