Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtcreator-qt6: 9.0.2 -> 10.0.0 #225306

Merged
merged 1 commit into from
Apr 25, 2023
Merged

qtcreator-qt6: 9.0.2 -> 10.0.0 #225306

merged 1 commit into from
Apr 25, 2023

Conversation

wineee
Copy link
Member

@wineee wineee commented Apr 8, 2023 •
edited
Loading

Description of changes

https://www.qt.io/blog/qt-creator-10-released

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wineee wineee force-pushed the qtcreator-qt6-10 branch from 12710e1 to 6299737 Compare April 8, 2023 15:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 8, 2023
@wineee wineee marked this pull request as draft April 10, 2023 09:30
@wineee
Copy link
Member Author

wineee commented Apr 10, 2023 •
edited
Loading

It's unstable for me
wait qt 6.5.0 (#224469)

@wegank wegank marked this pull request as ready for review April 18, 2023 12:51
@wegank
Copy link
Member

wegank commented Apr 18, 2023

@ofborg build qtcreator-qt6 qtcreator-qt6.passthru.tests

@wineee
Copy link
Member Author

wineee commented Apr 19, 2023 •
edited
Loading

QML language server plugin crashes frequently，Maybe fix by #202223

@wineee wineee force-pushed the qtcreator-qt6-10 branch from 6299737 to 169e2e1 Compare April 19, 2023 03:14
@wineee
Copy link
Member Author

wineee commented Apr 19, 2023

How can I fetch qtcreator-qt6 build by ofborg ? I don't want to compile qtwebengine

@wegank
Copy link
Member

wegank commented Apr 19, 2023 •
edited
Loading

You can't: NixOS/ofborg#68

Anyway, I think you can just revert the last commit on qt6.qtwebengine to get a functioning build from Hydra.

@wegank
Copy link
Member

wegank commented Apr 22, 2023

Any update on this PR?

@wineee
Copy link
Member Author

wineee commented Apr 23, 2023

Still haven't tested the situation under qt 6.5, qtwebengine inevitably needs to be recompiled，qt6 packaging has changed a lot

Refer to the experience of Arch, there should be no need to adjust： archlinux/svntogit-packages@6058cf5

@wegank
Copy link
Member

wegank commented Apr 23, 2023

Still haven't tested the situation under qt 6.5, qtwebengine inevitably needs to be recompiled，qt6 packaging has changed a lot

I believe qt6.qtwebengine has been built and cached on cache.nixos.org, and nixpkgs-review should work without rebuilding Qt. Maybe you just need to rebase locally?

@wineee wineee force-pushed the qtcreator-qt6-10 branch from 169e2e1 to 8a3121c Compare April 25, 2023 02:27
@wineee
Copy link
Member Author

wineee commented Apr 25, 2023

image

Basically, LGTM

@wegank wegank merged commit aab374c into NixOS:master Apr 25, 2023
@wineee wineee deleted the qtcreator-qt6-10 branch April 25, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wineee @wegank