Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xgboost: 1.7.4 -> 1.7.5 #224150

Merged
merged 1 commit into from
Apr 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions pkgs/development/libraries/xgboost/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
, llvmPackages
, R
, rPackages
}:
}@inputs:

assert ncclSupport -> cudaSupport;
# Disable regular tests when building the R package
Expand All @@ -22,6 +22,14 @@ assert ncclSupport -> cudaSupport;
# tests.
assert rLibrary -> doCheck != true;

let
# This ensures xgboost gets the correct libstdc++ when
# built with cuda support. This may be removed once
# #226165 rewrites cudaStdenv
inherit (cudaPackages) backendStdenv;
stdenv = if cudaSupport then backendStdenv else inputs.stdenv;
in

stdenv.mkDerivation rec {
pnameBase = "xgboost";
# prefix with r when building the R library
Expand All @@ -37,14 +45,14 @@ stdenv.mkDerivation rec {
# in \
# rWrapper.override{ packages = [ xgb ]; }"
pname = lib.optionalString rLibrary "r-" + pnameBase;
version = "1.7.4";
version = "1.7.5";

src = fetchFromGitHub {
owner = "dmlc";
repo = pnameBase;
rev = "v${version}";
fetchSubmodules = true;
hash = "sha256-HGS9w4g2+Aw5foKjHK/XQvSCnFHUswhzAsQf6XkdvOI=";
hash = "sha256-IBqtyz40VVHdncibnZQAe5oDsjb5isWBYQ6pGx/zt38=";
};

nativeBuildInputs = [ cmake ]
Expand Down